Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port the gateway release candidate + use forge #3212

Open
wants to merge 74 commits into
base: sync-layer-stable
Choose a base branch
from
Open

Port the gateway release candidate + use forge #3212

wants to merge 74 commits into from
+3,171 −544

Conversation

StanislavBreadless
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited
Loading

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Examples of valid PR titles:

  • feat(eth_sender): Support new transaction type
  • fix(state_keeper): Correctly handle edge case
  • ci: Add new workflow for linting

Details:

No release type found in pull request title "Port the gateway release candidate + use forge". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

perekopskiy
perekopskiy reviewed Nov 1, 2024
View reviewed changes
Copy link
Contributor

@perekopskiy perekopskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed upgrade part in zkstack_cli yet

core/lib/basic_types/src/protocol_version.rs Outdated Show resolved Hide resolved
core/lib/contracts/src/lib.rs Show resolved Hide resolved
core/lib/contracts/src/lib.rs Show resolved Hide resolved
core/lib/dal/src/factory_deps_dal.rs Outdated Show resolved Hide resolved
core/lib/dal/src/factory_deps_dal.rs Outdated Show resolved Hide resolved
core/node/eth_watch/src/event_processors/mod.rs Outdated Show resolved Hide resolved
core/node/eth_watch/src/tests.rs Outdated
Comment on lines 161 to 167
async fn get_published_preimages(
&self,
_hashes: Vec<H256>,
) -> EnrichedClientResult<Vec<Option<Vec<u8>>>> {
Ok(vec![])
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have some unit test with factory dep in upgrade

core/node/node_framework/src/implementations/layers/eth_watch.rs Outdated Show resolved Hide resolved
zkstack_cli/crates/common/src/hardhat.rs Outdated Show resolved Hide resolved
zkstack_cli/crates/config/src/consts.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perekopskiy perekopskiy perekopskiy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanislavBreadless @perekopskiy